Fixes scan-build issues #174

miyazakh · 2025-09-17T21:55:14Z

Fixes issues on scan-build LLVM-19

scan-build --status-bugs make -C test/ 
scan-build --status-bugs make -C benchmark/ 
scan-build --status-bugs make -C examples/ 
scan-build --status-bugs make -C tools/whnvmtool/

There is one issue, which is warning: Value stored to 'ret' is never read in wolfcrypt\src\random.c against tools/whnvmtool/, remaining. That will be separately fixed.

Github action addition for changes in the future will be submitted as separate PR.

JacobBarthelmeh

Overall looks great. Only thing that stood out to me is the loss of capturing return values. I think we should act on the return values if scan-build is complaining about them not being used, or the internal function should be changed to a void return if no return values are expected.

src/wh_nvm_flash.c

examples/demo/client/wh_demo_client_secboot.c

src/wh_nvm_flash.c

test/wh_test_clientserver.c

test/wh_test_crypto.c

bigbrett · 2025-09-23T21:27:57Z

@miyazakh looks like there are merge conflicts. Can you please address my comments as well as resolve them.

I also would like to see scan-build integrated as a GH action

src/wh_nvm_flash.c

miyazakh · 2025-09-24T19:06:16Z

clang-tidy starts complaining to wh_server_keystore.c even though the PR doesn't touch it.

bigbrett · 2025-09-25T03:29:56Z

clang-tidy starts complaining to wh_server_keystore.c even though the PR doesn't touch it.

@miyazakh Should be fixed if you rebase on main, sorry about that!

billphipps

Looks good! A few minor suggestions and a couple of questions. This should be merged prior to #158.

src/wh_nvm_flash.c

src/wh_server_crypto.c

test/wh_test_clientserver.c

src/wh_server_crypto.c

src/wh_nvm_flash.c

billphipps

Lots of excellent fixes and finds! Thank you!

I recommend we ignore some of the error returns as in the original code. Let me know if you agree or if we should find an alternate path on how to handle secondary errors.

I think exiting early during reading the NVM directory objects is an error and must be corrected.

src/wh_nvm_flash.c

src/wh_server_crypto.c

bigbrett · 2025-10-02T14:35:54Z

@billphipps please merge when you are ok with it

billphipps

Looks great! Thanks!

miyazakh assigned miyazakh and wolfSSL-Bot and unassigned miyazakh Sep 17, 2025

JacobBarthelmeh reviewed Sep 18, 2025

View reviewed changes

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

bigbrett requested changes Sep 18, 2025

View reviewed changes

bigbrett assigned miyazakh and unassigned wolfSSL-Bot Sep 23, 2025

miyazakh force-pushed the scan_build_issues branch from 6713d08 to bb24508 Compare September 24, 2025 07:02

bigbrett requested changes Sep 24, 2025

View reviewed changes

src/wh_nvm_flash.c Show resolved Hide resolved

miyazakh force-pushed the scan_build_issues branch from 1e376cb to d49d232 Compare September 24, 2025 18:33

miyazakh force-pushed the scan_build_issues branch from d49d232 to 20d3f1a Compare September 25, 2025 11:36

billphipps requested changes Sep 25, 2025

View reviewed changes

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

src/wh_server_crypto.c Outdated Show resolved Hide resolved

src/wh_server_crypto.c Outdated Show resolved Hide resolved

test/wh_test_clientserver.c Outdated Show resolved Hide resolved

bigbrett requested changes Sep 25, 2025

View reviewed changes

src/wh_server_crypto.c Outdated Show resolved Hide resolved

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

miyazakh force-pushed the scan_build_issues branch from 52f9be3 to 6e5cac2 Compare September 26, 2025 17:18

miyazakh assigned bigbrett and unassigned miyazakh Sep 27, 2025

miyazakh added 11 commits September 28, 2025 10:10

scan-build fixes

b43c135

run clang-format

9947fcf

Addressed code review

40f2aa5

add (void) to rfMemObject_Read

939c031

undo the change for nfMemObject_Read

c8de5eb

run clang-format again

faf0b89

Addressed code review

df298cc

change casting return value from wh_Server_KeystoreEvictKey

1d506a9

fix clang-tidy warnings

23ae11c

run clang-format again

768292c

correct rebase

23f75fd

additional fix for scan biuld issue in examples

3ea1f22

miyazakh force-pushed the scan_build_issues branch from 806a491 to 3ea1f22 Compare September 28, 2025 14:28

This was referenced Sep 28, 2025

Add GH action for scan build #190

Closed

Add scan build github action #195

Merged

bug: Clang's scan-build identifies multiple un-checked return values #165

Closed

billphipps requested changes Sep 30, 2025

View reviewed changes

src/wh_nvm_flash.c Outdated Show resolved Hide resolved

src/wh_server_crypto.c Outdated Show resolved Hide resolved

miyazakh force-pushed the scan_build_issues branch from 6c01197 to 52dfdb3 Compare October 1, 2025 11:34

revert to the original when user wants to do so

1bbcd35

miyazakh force-pushed the scan_build_issues branch from 52dfdb3 to 1bbcd35 Compare October 1, 2025 11:39

bigbrett self-requested a review October 2, 2025 14:34

bigbrett approved these changes Oct 2, 2025

View reviewed changes

billphipps approved these changes Oct 2, 2025

View reviewed changes

billphipps merged commit 1eda4bc into wolfSSL:main Oct 2, 2025
10 checks passed

miyazakh deleted the scan_build_issues branch October 2, 2025 14:43

Fixes scan-build issues #174

Fixes scan-build issues #174

Uh oh!

Conversation

miyazakh commented Sep 17, 2025

Uh oh!

JacobBarthelmeh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigbrett commented Sep 23, 2025

Uh oh!

Uh oh!

miyazakh commented Sep 24, 2025

Uh oh!

bigbrett commented Sep 25, 2025

Uh oh!

billphipps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

billphipps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bigbrett commented Oct 2, 2025

Uh oh!

billphipps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants